Skip to content

Updates logj4 to 2.20.0#7586

Closed
owaiskazi19 wants to merge 1 commit intoopensearch-project:mainfrom
owaiskazi19:log4j-update
Closed

Updates logj4 to 2.20.0#7586
owaiskazi19 wants to merge 1 commit intoopensearch-project:mainfrom
owaiskazi19:log4j-update

Conversation

@owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented May 16, 2023 •
edited
Loading

Description

Since https://issues.apache.org/jira/browse/LOG4J2-3562 has been resolved. Trying to update the version of log4j.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19 owaiskazi19 mentioned this pull request May 16, 2023
Merged
@owaiskazi19
Update logj4 to 2.20.0
dbccbdb 
Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

Gradle Check (Jenkins) Run Completed with:

@owaiskazi19 owaiskazi19 changed the title Update logj4 to 2.20.0 Updates logj4 to 2.20.0 May 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

Gradle Check (Jenkins) Run Completed with:

@owaiskazi19
Copy link
Member Author

owaiskazi19 commented May 17, 2023 •
edited
Loading

@reta any idea for the test failures? Most of them are failing with the below reason

org.opensearch.plugins.InstallPluginCommandTests > testPluginsHelpNonOptionArgumentsOutput {p0=sun.nio.fs.LinuxFileSystem@10728fe8 p1=org.opensearch.plugins.InstallPluginCommandTests$$Lambda$260/0x0000000801286df0@16fb9fdd} FAILED
    java.lang.AssertionError: 
    Expected: an empty collection
         but: <[The use of package scanning to locate plugins is deprecated and will be removed in a future release]>
        at __randomizedtesting.SeedInfo.seed([986E2ABB1E0BE95E:538622131BDD3131]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.test.OpenSearchTestCase.checkStaticState(OpenSearchTestCase.java:636)
        at org.opensearch.test.OpenSearchTestCase.after(OpenSearchTestCase.java:426)
        at java.****/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
        at java.****/java.lang.reflect.Method.invoke(Method.java:578)
        at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)

@reta
Copy link
Contributor

reta commented May 17, 2023

@reta any idea for the test failures? Most of them are failing with the below reason

@owaiskazi19 this is one of the changes that went into Log4j 2.20: https://issues.apache.org/jira/browse/LOG4J2-3644, I suspect that our test framework expect no log statement to be emitted but there are some (like such deprecations).

@opensearch-trigger-bot
Copy link
Contributor

opensearch-trigger-bot bot commented Jun 22, 2023

This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jun 22, 2023
@reta reta mentioned this pull request Jun 28, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stephen-crawford stephen-crawford stephen-crawford approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stalled Issues that have stalled

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@owaiskazi19 @reta @stephen-crawford

Comments